deps: update libuv to 1.52.1 by nodejs-github-bot · Pull Request #61829 · nodejs/node

nodejs-github-bot · 2026-02-15T00:52:06Z

This is an automated update of libuv to 1.52.1.

nodejs-github-bot · 2026-02-15T00:52:11Z

Review requested:

@nodejs/security-wg

github-actions · 2026-02-15T09:02:44Z

Failed to start CI

- Validating Jenkins credentials
✔  Jenkins credentials valid
- Starting PR CI job
✘  Failed to start PR CI: 404 Not Found

https://github.com/nodejs/node/actions/runs/22032932485

nodejs-github-bot · 2026-02-18T14:22:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71354/

aduh95 · 2026-02-18T16:53:58Z

There seems to be a related failure on Windows:

stack: |-
  node:internal/assert/utils:146
    throw error;
    ^

  AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
  + actual - expected

  + 'write EPIPE'
  - 'write EBADF'
            ^

      at Socket.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\parallel\test-net-socket-write-after-close.js:15:16)
      at Socket.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\common\index.js:507:15)
      at Socket.emit (node:events:508:20)
      at emitErrorNT (node:internal/streams/destroy:170:8)
      at emitErrorCloseNT (node:internal/streams/destroy:129:3)
      at process.processTicksAndRejections (node:internal/process/task_queues:90:21) {
    generatedMessage: true,
    code: 'ERR_ASSERTION',
    actual: 'write EPIPE',
    expected: 'write EBADF',
    operator: 'strictEqual',
    diff: 'simple'
  }

  Node.js v26.0.0-pre

StefanStojanovic · 2026-02-19T13:58:31Z

I've taken a look at this. First of all, both native and JS tests (some other than the one mentioned in a previous comment) failed, so I reran the 2 jobs (native, JS), and the only failure left is the one from parallel.test-net-socket-write-after-close.

The reason for the failure seems to be the change from this PR. I do not know how the others feel, but for me personally, changing the expected behavior to a new error doesn't seem like a big issue and I'd go with that approach. Of course, I leave the option that there is something that would not allow this that I'm not aware of, so if there is, please let me know.

StefanStojanovic · 2026-03-02T14:54:43Z

Hey all, just wanted to ping here again about the Windows test failure and my suggestion to fix it - changing the error we expect in the test. If there are some objections to that approach, please let me know. Otherwise, I'll push the change to the test on Thursday/Friday this week.

codecov · 2026-03-09T10:52:18Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.65%. Comparing base (3725bd2) to head (3622960).
⚠️ Report is 42 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #61829   +/-   ##
=======================================
  Coverage   89.65%   89.65%           
=======================================
  Files         676      676           
  Lines      206543   206546    +3     
  Branches    39547    39541    -6     
=======================================
+ Hits       185184   185188    +4     
- Misses      13480    13493   +13     
+ Partials     7879     7865   -14

see 54 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95 · 2026-03-10T12:27:49Z

@StefanStojanovic looks like your change breaks every other platforms though

StefanStojanovic · 2026-03-10T14:00:11Z

@StefanStojanovic looks like your change breaks every other platforms though

Well, at least now it's no longer my problem, Windows works well... xD Just kidding, will put a isWindows check in that test

nodejs-github-bot · 2026-03-12T21:50:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71732/

nodejs-github-bot · 2026-03-14T18:52:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71766/

juanarbol · 2026-03-14T18:57:10Z

Marking as requested for v24.x via #62232

Renegade334 · 2026-03-14T19:37:44Z

(lands cleanly!)

nodejs-github-bot · 2026-03-15T02:41:32Z

Commit Queue failed

- Loading data for nodejs/node/pull/61829
✔  Done loading data for nodejs/node/pull/61829
----------------------------------- PR info ------------------------------------
Title      deps: update libuv to 1.52.1 (#61829)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/tools-update-libuv -> nodejs:main
Labels     libuv, author ready, needs-ci, dependencies, lts-watch-v24.x
Commits    1
 - deps: update libuv to 1.52.1
Committers 1
 - github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/61829
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/61829
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - deps: update libuv to 1.52.1
   ℹ  This PR was created on Sun, 15 Feb 2026 00:52:06 GMT
   ✔  Approvals: 6
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/61829#pullrequestreview-3803977138
   ✔  - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/61829#pullrequestreview-3805075669
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/61829#pullrequestreview-3805249263
   ✔  - Santiago Gimeno (@santigimeno): https://github.com/nodejs/node/pull/61829#pullrequestreview-3805558272
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/61829#pullrequestreview-3915039213
   ✔  - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/61829#pullrequestreview-3949140194
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2026-03-14T18:52:12Z: https://ci.nodejs.org/job/node-test-pull-request/71766/
   ⚠  Commits were pushed after the last Full PR CI run:
   ⚠  - deps: update libuv to 1.52.1
- Querying data for job/node-test-pull-request/71766/
✔  Build data downloaded
- Querying failures of job/node-test-commit/85981/
✔  Data downloaded
   ✘  7 failure(s) on the last Jenkins CI run
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/23101775390

nodejs-github-bot · 2026-03-15T14:29:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71770/

nodejs-github-bot · 2026-03-15T15:44:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71774/

nodejs-github-bot · 2026-03-15T15:52:22Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71775/

nodejs-github-bot · 2026-03-15T16:39:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71776/

nodejs-github-bot · 2026-03-15T16:48:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71777/

nodejs-github-bot · 2026-03-15T20:48:10Z

Commit Queue failed

- Loading data for nodejs/node/pull/61829 ✔ Done loading data for nodejs/node/pull/61829 ----------------------------------- PR info ------------------------------------ Title deps: update libuv to 1.52.1 (#61829) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/tools-update-libuv -> nodejs:main Labels libuv, author ready, needs-ci, dependencies, lts-watch-v24.x Commits 2 - deps: update libuv to 1.52.1 - test: fix assert for libuv v1.52.1 Committers 2 - github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> - StefanStojanovic <stefan.stojanovic@janeasystems.com> PR-URL: https://github.com/nodejs/node/pull/61829 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/61829 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 15 Feb 2026 00:52:06 GMT ✔ Approvals: 6 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/61829#pullrequestreview-3803977138 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/61829#pullrequestreview-3805075669 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/61829#pullrequestreview-3805249263 ✔ - Santiago Gimeno (@santigimeno): https://github.com/nodejs/node/pull/61829#pullrequestreview-3805558272 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/61829#pullrequestreview-3915039213 ✔ - Juan José Arboleda (@juanarbol): https://github.com/nodejs/node/pull/61829#pullrequestreview-3949140194 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-03-15T16:48:13Z: https://ci.nodejs.org/job/node-test-pull-request/71777/ - Querying data for job/node-test-pull-request/71777/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 61829 From https://github.com/nodejs/node * branch refs/pull/61829/merge -> FETCH_HEAD ✔ Fetched commits as 82409af5a27f..3622960573c0 -------------------------------------------------------------------------------- [main 7b8f523257] deps: update libuv to 1.52.1 Author: nodejs-github-bot <18269663+nodejs-github-bot@users.noreply.github.com> Date: Sun Mar 8 00:49:12 2026 +0000 121 files changed, 2884 insertions(+), 1389 deletions(-) create mode 100644 deps/uv/.clang-tidy delete mode 100644 deps/uv/src/win/atomicops-inl.h create mode 100644 deps/uv/test/test-udp-recv-cb-close-pollerr.c create mode 100644 deps/uv/test/test-udp-recvmsg-unreachable-error.c [main 1d60416c1e] test: fix assert for libuv v1.52.1 Author: StefanStojanovic <stefan.stojanovic@janeasystems.com> Date: Tue Mar 10 15:08:17 2026 +0100 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. (node:447) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated. (Use `node --trace-deprecation ...` to show where the warning was created) Rebasing (2/4) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- deps: update libuv to 1.52.1

PR-URL: #61829
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

[detached HEAD 890b55a345] deps: update libuv to 1.52.1
Author: nodejs-github-bot <18269663+nodejs-github-bot@users.noreply.github.com>
Date: Sun Mar 8 00:49:12 2026 +0000
121 files changed, 2884 insertions(+), 1389 deletions(-)
create mode 100644 deps/uv/.clang-tidy
delete mode 100644 deps/uv/src/win/atomicops-inl.h
create mode 100644 deps/uv/test/test-udp-recv-cb-close-pollerr.c
create mode 100644 deps/uv/test/test-udp-recvmsg-unreachable-error.c
Rebasing (3/4)
Rebasing (4/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
test: fix assert for libuv v1.52.1

PR-URL: #61829
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

[detached HEAD 8860752351] test: fix assert for libuv v1.52.1
Author: StefanStojanovic <stefan.stojanovic@janeasystems.com>
Date: Tue Mar 10 15:08:17 2026 +0100
1 file changed, 1 insertion(+), 1 deletion(-)
Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/23118941682

nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Feb 15, 2026

nodejs-github-bot added libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run. labels Feb 15, 2026

aduh95 approved these changes Feb 15, 2026

View reviewed changes

aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 15, 2026

github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Feb 15, 2026

cjihrig approved these changes Feb 15, 2026

View reviewed changes

lpinca approved these changes Feb 15, 2026

View reviewed changes

lpinca added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Feb 15, 2026

santigimeno approved these changes Feb 15, 2026

View reviewed changes

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2026

nodejs-github-bot force-pushed the actions/tools-update-libuv branch from 6a25a76 to 5915071 Compare February 22, 2026 00:49

nodejs-github-bot force-pushed the actions/tools-update-libuv branch from 5915071 to d240140 Compare March 1, 2026 00:54

deps: update libuv to 1.52.1

d282cbb

nodejs-github-bot changed the title ~~deps: update libuv to 1.52.0~~ deps: update libuv to 1.52.1 Mar 8, 2026

nodejs-github-bot force-pushed the actions/tools-update-libuv branch from d240140 to d282cbb Compare March 8, 2026 00:49

RafaelGSS approved these changes Mar 9, 2026

View reviewed changes

test: fix assert for libuv v1.52.1

3622960

Renegade334 mentioned this pull request Mar 12, 2026

On Windows arm64 os.machine() returns unknown #62232

Open

Renegade334 linked an issue Mar 12, 2026 that may be closed by this pull request

On Windows arm64 os.machine() returns unknown #62232

Open

zakiscoding mentioned this pull request Mar 13, 2026

fix(os): return 'arm64' from os.machine() on Windows ARM64 (fix #62232) #62235

Closed

juanarbol approved these changes Mar 14, 2026

View reviewed changes

juanarbol added the backport-requested-v24.x PRs awaiting manual backport to the v24.x-staging branch. label Mar 14, 2026

Renegade334 added lts-watch-v24.x PRs that may need to be released in v24.x and removed backport-requested-v24.x PRs awaiting manual backport to the v24.x-staging branch. labels Mar 14, 2026

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 14, 2026

nodejs-github-bot force-pushed the actions/tools-update-libuv branch from 3622960 to b6996a1 Compare March 15, 2026 00:55

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 15, 2026

aduh95 force-pushed the actions/tools-update-libuv branch from b6996a1 to 3622960 Compare March 15, 2026 14:28

juanarbol added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Mar 15, 2026

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 15, 2026

Uh oh!

Conversation

nodejs-github-bot commented Feb 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Feb 15, 2026

Uh oh!

github-actions bot commented Feb 15, 2026

Uh oh!

nodejs-github-bot commented Feb 18, 2026

Uh oh!

aduh95 commented Feb 18, 2026

Uh oh!

StefanStojanovic commented Feb 19, 2026

Uh oh!

StefanStojanovic commented Mar 2, 2026

Uh oh!

codecov bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aduh95 commented Mar 10, 2026

Uh oh!

StefanStojanovic commented Mar 10, 2026

Uh oh!

nodejs-github-bot commented Mar 12, 2026

Uh oh!

nodejs-github-bot commented Mar 14, 2026

Uh oh!

juanarbol commented Mar 14, 2026

Uh oh!

Renegade334 commented Mar 14, 2026

Uh oh!

nodejs-github-bot commented Mar 15, 2026

Uh oh!

nodejs-github-bot commented Mar 15, 2026

Uh oh!

nodejs-github-bot commented Mar 15, 2026

Uh oh!

nodejs-github-bot commented Mar 15, 2026

Uh oh!

nodejs-github-bot commented Mar 15, 2026

Uh oh!

nodejs-github-bot commented Mar 15, 2026

Uh oh!

nodejs-github-bot commented Mar 15, 2026

[detached HEAD 8860752351] test: fix assert for libuv v1.52.1 Author: StefanStojanovic <stefan.stojanovic@janeasystems.com> Date: Tue Mar 10 15:08:17 2026 +0100 1 file changed, 1 insertion(+), 1 deletion(-) Successfully rebased and updated refs/heads/main.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

nodejs-github-bot commented Feb 15, 2026 •

edited

Loading

codecov bot commented Mar 9, 2026 •

edited

Loading

[detached HEAD 8860752351] test: fix assert for libuv v1.52.1
Author: StefanStojanovic <stefan.stojanovic@janeasystems.com>
Date: Tue Mar 10 15:08:17 2026 +0100
1 file changed, 1 insertion(+), 1 deletion(-)
Successfully rebased and updated refs/heads/main.